From 0d348015a0f342c6fdf20da2c042a0c5f39bd372 Mon Sep 17 00:00:00 2001 From: Ajay Krishnan Date: Wed, 9 Sep 2026 11:39:06 -0700 Subject: [PATCH] Move the test suite to minitest 6 minitest 6 removed minitest/mock. Verified directly: $ ruby -e 'gem "minitest", "6.0.6"; require "minitest/mock"' LoadError: cannot load such file -- minitest/mock The suite depends on Object#stub with a lambda for Net::HTTP, File and Tempfile, so this is not a pin that can simply be relaxed. Object#stub now ships in the extracted minitest-mock gem, which is declared here as a development dependency and required explicitly from the test helper, since minitest/autorun no longer pulls it in. Confirmed that minitest 6.0.6 with minitest-mock 5.27.0 restores lambda stubbing before making the change. minitest 6 requires Ruby >= 3.2, which matches this gem's required_ruby_version and the full CI matrix. marcel 2.1.0 is available and is deliberately NOT taken: it requires Ruby >= 3.3, while this gem supports >= 3.2 and tests 3.2 in CI. Taking it would silently narrow the supported Ruby range. No .ruby-version is added and no lockfile is committed: both are gitignored here on purpose, because a library resolves against its consumers and supports a Ruby range rather than a pin. vendor/ is added to .gitignore so a local bundle install does not show up as untracked files. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01Rch35u85D3buqx7wEsCVki --- .gitignore | 1 + opencode-ruby.gemspec | 5 ++++- test/test_helper.rb | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 290f8a8..695c5d0 100644 --- a/.gitignore +++ b/.gitignore @@ -6,3 +6,4 @@ tmp/ .ruby-version .byebug_history coverage/ +vendor/ diff --git a/opencode-ruby.gemspec b/opencode-ruby.gemspec index 31076fd..68de932 100644 --- a/opencode-ruby.gemspec +++ b/opencode-ruby.gemspec @@ -35,7 +35,10 @@ Gem::Specification.new do |spec| spec.add_runtime_dependency "activesupport", ">= 6.1", "< 9.0" spec.add_runtime_dependency "marcel", "~> 1.0" - spec.add_development_dependency "minitest", "~> 5.20" + # minitest 6 removed minitest/mock; Object#stub now ships in the extracted + # minitest-mock gem, which the suite uses to stub Net::HTTP, File and Tempfile. + spec.add_development_dependency "minitest", "~> 6.0" + spec.add_development_dependency "minitest-mock", "~> 5.27" spec.add_development_dependency "rake", "~> 13.0" spec.add_development_dependency "webmock", "~> 3.20" end diff --git a/test/test_helper.rb b/test/test_helper.rb index 272f31a..3c2f0c2 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -4,6 +4,7 @@ $LOAD_PATH.unshift File.expand_path("../lib", __dir__) require "opencode-ruby" require "minitest/autorun" +require "minitest/mock" require "webmock/minitest" # Tests run against WebMock-stubbed endpoints; never hit the network.