Ajay Krishnan
08ab6ea6fc
Sandi S2 (smoke coverage was 4/12) + Tobi T7 (adapter exception path
untested) consensus actions. 38 new tests across 9 files take total
from 15 -> 53 tests, 50 -> 134 assertions.
Per-class breakdown:
session_test.rb (2 tests)
Contract on initialize parameters (positional record + keyword
callables) and public surface (ensure!/recreate!/abort!/just_created?).
AR fixtures stay in the host suite.
turn_test.rb (4 tests)
Required + optional keyword arg contracts (locks the 9 required
+ 8 optional keys against drift). Public surface = [:call] only.
Result struct exercised as a value object with status predicates
and cost/token delegation.
message_artifacts_test.rb (2 tests)
Contract on initialize parameters; public surface = [:attach_from].
impostor_test.rb (3 tests)
Initialize keyword contract; delegation to ActiveStorage attachment
via a Struct double on #filename.
sandbox_test.rb (5 tests)
Real tmpdir instantiation: #path / #exists? / #files (Enumerator
when block-less, yields SandboxFile values when files present) /
#file lookup-by-basename returns nil for missing.
sandbox_file_test.rb (4 tests)
Real tmpdir + file: basic readers, marcel-backed content_type
detection, #safe? size-cap rejection, #as_artifact identity
conversion returns Opencode::Artifact.
transform_test.rb (8 tests)
Documents the abstract contract (source_filename / destination_filename /
render all raise NotImplementedError). A trivial concrete subclass
inside the test exercises the default implementations of
#applies_to?, #trusted?, #owned_filenames, and #purge_impostors?
that delegate to the two abstract filename methods.
tool_display_test.rb (5 tests)
Known tool canonicalization, status predicates (running/completed/
errored/in_flight/terminal), unknown-tool fallback, nil-part
tolerance (callers sometimes pass non-tool parts_json entries).
uploaded_files_prompt_test.rb (3 tests)
Initialize keyword contract; #text returns raw content + empty
sandbox_file_names map when no files attached; public surface check.
Plus 2 new tests in error_reporter_test.rb (C4):
- test_adapter_exceptions_propagate: adapter that raises must
propagate, not silently swallow — operators need to know the
error tracker is broken.
- test_report_returns_adapter_return_value: report passes through
the adapter's return value verbatim (Rails.error.report returns
the error itself; callers can chain).
Faithful to actual implementations: every test was first written from
the API I expected, then corrected against the class internals when
errors surfaced. The corrections themselves document the contract:
SandboxFile expects a String sandbox_prefix with trailing separator
(not a Pathname), Transform's filename methods are abstract not
nil-defaulting, etc.
63 lines
2.1 KiB
Ruby
63 lines
2.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "test_helper"
|
|
require "fileutils"
|
|
require "tmpdir"
|
|
require "marcel" # SandboxFile#content_type uses Marcel::MimeType.for
|
|
|
|
# Smoke test for Opencode::SandboxFile: instantiate against a real
|
|
# pathname, verify basename/size/content/content_type readers and the
|
|
# identity conversion to Opencode::Artifact via #as_artifact.
|
|
class Opencode::SandboxFileTest < Minitest::Test
|
|
def setup
|
|
@tmpdir = Dir.mktmpdir("opencode-rails-sandbox-file-test-")
|
|
@path = File.join(@tmpdir, "notes.md")
|
|
File.write(@path, "# hello\nworld\n")
|
|
# SandboxFile uses `start_with?` against this prefix to detect path
|
|
# escape; it expects a String with trailing separator so that
|
|
# /sandbox-1 doesn't false-positive on /sandbox-10/foo.
|
|
@sandbox_prefix = File.join(@tmpdir, "")
|
|
end
|
|
|
|
def teardown
|
|
FileUtils.remove_entry(@tmpdir) if @tmpdir && File.exist?(@tmpdir)
|
|
end
|
|
|
|
def test_basic_readers
|
|
file = Opencode::SandboxFile.new(
|
|
path: @path, sandbox_prefix: @sandbox_prefix, max_bytes: 10_000
|
|
)
|
|
|
|
assert_equal "notes.md", file.basename
|
|
assert file.size.positive?
|
|
assert_equal "# hello\nworld\n", file.content
|
|
assert file.safe?, "small text file inside sandbox should be safe"
|
|
end
|
|
|
|
def test_content_type_detection_via_marcel
|
|
file = Opencode::SandboxFile.new(
|
|
path: @path, sandbox_prefix: @sandbox_prefix, max_bytes: 10_000
|
|
)
|
|
# Marcel detects .md as text/markdown.
|
|
assert_match(/markdown|text/, file.content_type)
|
|
end
|
|
|
|
def test_safe_rejects_files_over_size_cap
|
|
file = Opencode::SandboxFile.new(
|
|
path: @path, sandbox_prefix: @sandbox_prefix, max_bytes: 5
|
|
)
|
|
refute file.safe?, "file larger than max_bytes must be unsafe"
|
|
end
|
|
|
|
def test_as_artifact_returns_opencode_artifact_value
|
|
file = Opencode::SandboxFile.new(
|
|
path: @path, sandbox_prefix: @sandbox_prefix, max_bytes: 10_000
|
|
)
|
|
|
|
artifact = file.as_artifact
|
|
assert_instance_of Opencode::Artifact, artifact
|
|
assert_equal "notes.md", artifact.filename
|
|
assert_equal "# hello\nworld\n", artifact.content
|
|
end
|
|
end
|