Ajay Krishnan
08ab6ea6fc
Sandi S2 (smoke coverage was 4/12) + Tobi T7 (adapter exception path
untested) consensus actions. 38 new tests across 9 files take total
from 15 -> 53 tests, 50 -> 134 assertions.
Per-class breakdown:
session_test.rb (2 tests)
Contract on initialize parameters (positional record + keyword
callables) and public surface (ensure!/recreate!/abort!/just_created?).
AR fixtures stay in the host suite.
turn_test.rb (4 tests)
Required + optional keyword arg contracts (locks the 9 required
+ 8 optional keys against drift). Public surface = [:call] only.
Result struct exercised as a value object with status predicates
and cost/token delegation.
message_artifacts_test.rb (2 tests)
Contract on initialize parameters; public surface = [:attach_from].
impostor_test.rb (3 tests)
Initialize keyword contract; delegation to ActiveStorage attachment
via a Struct double on #filename.
sandbox_test.rb (5 tests)
Real tmpdir instantiation: #path / #exists? / #files (Enumerator
when block-less, yields SandboxFile values when files present) /
#file lookup-by-basename returns nil for missing.
sandbox_file_test.rb (4 tests)
Real tmpdir + file: basic readers, marcel-backed content_type
detection, #safe? size-cap rejection, #as_artifact identity
conversion returns Opencode::Artifact.
transform_test.rb (8 tests)
Documents the abstract contract (source_filename / destination_filename /
render all raise NotImplementedError). A trivial concrete subclass
inside the test exercises the default implementations of
#applies_to?, #trusted?, #owned_filenames, and #purge_impostors?
that delegate to the two abstract filename methods.
tool_display_test.rb (5 tests)
Known tool canonicalization, status predicates (running/completed/
errored/in_flight/terminal), unknown-tool fallback, nil-part
tolerance (callers sometimes pass non-tool parts_json entries).
uploaded_files_prompt_test.rb (3 tests)
Initialize keyword contract; #text returns raw content + empty
sandbox_file_names map when no files attached; public surface check.
Plus 2 new tests in error_reporter_test.rb (C4):
- test_adapter_exceptions_propagate: adapter that raises must
propagate, not silently swallow — operators need to know the
error tracker is broken.
- test_report_returns_adapter_return_value: report passes through
the adapter's return value verbatim (Rails.error.report returns
the error itself; callers can chain).
Faithful to actual implementations: every test was first written from
the API I expected, then corrected against the class internals when
errors surfaced. The corrections themselves document the contract:
SandboxFile expects a String sandbox_prefix with trailing separator
(not a Pathname), Transform's filename methods are abstract not
nil-defaulting, etc.
28 lines
1.2 KiB
Ruby
28 lines
1.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "test_helper"
|
|
|
|
# Contract smoke for Opencode::Session. Behavioral coverage (idempotent
|
|
# ensure!/recreate!/abort! with row-level locking, race-safety,
|
|
# permissions_for callable handoff) lives in the host application
|
|
# where AR fixtures + a real ActiveRecord row exist.
|
|
class Opencode::SessionTest < Minitest::Test
|
|
def test_initialize_takes_record_and_two_keyword_callables
|
|
params = Opencode::Session.instance_method(:initialize).parameters
|
|
|
|
assert_includes params, [ :req, :record ],
|
|
"Session must take a positional record (an AR row with #with_lock, #title, etc.)"
|
|
assert_includes params, [ :keyreq, :permissions_for ],
|
|
"Session must require a permissions_for: callable (host-injected per-product permissions)"
|
|
assert_includes params, [ :key, :on_error ],
|
|
"Session must accept an optional on_error: callable for adapter-style error reporting"
|
|
end
|
|
|
|
def test_public_api_is_ensure_recreate_abort_just_created
|
|
methods = Opencode::Session.instance_methods(false).sort
|
|
assert_equal %i[abort! ensure! just_created? recreate!].sort, methods.sort,
|
|
"Session's public surface should be exactly: ensure!/recreate!/abort!/just_created?. " \
|
|
"Found: #{methods.inspect}"
|
|
end
|
|
end
|