Port lib/opencode/rails/ source files; strip Rails.event/Rails.error
Eleven source files moved from ajent-rails:lib/opencode/rails/ to
opencode-rails:lib/opencode/ (flat layout — modules are Opencode::*, not
Opencode::Rails::*; matches opencode-ruby).
artifact.rb 63 LOC
exchange.rb 77 LOC
impostor.rb 48 LOC
message_artifacts.rb 133 LOC
sandbox_file.rb 81 LOC
sandbox.rb 71 LOC
session.rb 168 LOC
tool_display.rb 423 LOC
transform.rb 77 LOC
turn.rb 642 LOC
uploaded_files_prompt.rb 85 LOC
----
total 1,868 LOC
Surgical Rails strips:
exchange.rb:
Rails.event.notify(name, payload)
-> Opencode::Instrumentation.instrument(name, payload) { }
message_artifacts.rb (1 call), turn.rb (6 calls):
Rails.error.report(error, **opts)
-> Opencode::ErrorReporter.report(error, **opts)
Comments/docstrings referencing Rails.error.report / Rails.event left
in place — they document how to wire the host adapter.
ActiveSupport core_ext requires expanded in lib/opencode-rails.rb to
cover Numeric#seconds, Hash#deep_stringify_keys, String#squish/truncate,
String#demodulize. Bundle install + smoke load confirms all 12
gem-provided constants resolve cleanly.
This commit is contained in:
133
lib/opencode/message_artifacts.rb
Normal file
133
lib/opencode/message_artifacts.rb
Normal file
@@ -0,0 +1,133 @@
|
||||
# frozen_string_literal: true
|
||||
|
||||
module Opencode
|
||||
# The collection of new artifacts attached to an assistant message as
|
||||
# a result of one turn. The orchestrator that used to live in
|
||||
# Opencode::ArtifactCollector now lives on this collection — instead
|
||||
# of a "Collector" verb-class, the collection knows how to populate
|
||||
# itself from sources (tool exchange, sandbox) and how to attach.
|
||||
#
|
||||
# Two-line usage:
|
||||
#
|
||||
# Opencode::MessageArtifacts.new(message: m, feature: "blackline", transforms: [])
|
||||
# .attach_from(exchange: exchange, sandbox: sandbox)
|
||||
#
|
||||
# All four phases (tool extract, transform routing, impostor purge,
|
||||
# default sandbox attach) live as small named methods. The substrate
|
||||
# never special-cases a product — `:feature` is only for error-report
|
||||
# context, and `:transforms` (default []) is per-product policy.
|
||||
#
|
||||
# Idempotent under retry: `Opencode::Artifact#attach_to` already
|
||||
# skips when the filename is present on the message, and the
|
||||
# tool-extracted phase excludes filenames the transforms own.
|
||||
class MessageArtifacts
|
||||
MAX_SANDBOX_ARTIFACTS = 20
|
||||
|
||||
# default_attach values:
|
||||
# :all — Blackline/Raven default. Every safe sandbox file that
|
||||
# no transform claims falls through to identity attach.
|
||||
# The agent's `write` outputs are final document bytes the
|
||||
# host serves back unchanged.
|
||||
# :none — AIGL. The agent's sandbox is full of internal working
|
||||
# scratch (notes.md, map.md, timeline.md) plus the one
|
||||
# file the transform claims (flight-results.json). Only
|
||||
# transform-claimed files attach; everything else stays
|
||||
# agent-internal.
|
||||
def initialize(message:, feature:, transforms: [], default_attach: :all,
|
||||
max_sandbox_files: MAX_SANDBOX_ARTIFACTS)
|
||||
@message = message
|
||||
@feature = feature
|
||||
@transforms = transforms
|
||||
@default_attach = default_attach
|
||||
@max_sandbox_files = max_sandbox_files
|
||||
end
|
||||
|
||||
# Drains both sources and attaches. Returns self so callers can
|
||||
# chain off it if they want to count what landed.
|
||||
def attach_from(exchange: nil, sandbox: nil, cutoff: nil, upload_echo: [])
|
||||
attach_from_exchange(exchange) if exchange
|
||||
attach_from_sandbox(sandbox, cutoff: cutoff, upload_echo: upload_echo) if sandbox
|
||||
self
|
||||
rescue StandardError => e
|
||||
report(e, action: "attach_artifacts")
|
||||
self
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
attr_reader :message, :feature, :transforms, :max_sandbox_files, :default_attach
|
||||
|
||||
# Tool-produced artifacts (write tool's input content). Skip any
|
||||
# filename a transform owns — those land via the sandbox path so the
|
||||
# transform's trust pipeline (render + metadata stamp) is the only
|
||||
# way the bytes reach the user.
|
||||
def attach_from_exchange(exchange)
|
||||
exchange.tool_artifacts(exclude: transform_owned_filenames).each do |artifact|
|
||||
artifact.attach_to(message)
|
||||
end
|
||||
rescue StandardError => e
|
||||
report(e, action: "attach_from_exchange")
|
||||
end
|
||||
|
||||
def attach_from_sandbox(sandbox, cutoff:, upload_echo:)
|
||||
return unless sandbox.exists?
|
||||
|
||||
uploaded = Set.new(upload_echo)
|
||||
attached = 0
|
||||
|
||||
sandbox.files(after: cutoff).each do |file|
|
||||
break if attached >= max_sandbox_files
|
||||
next if uploaded.include?(file.basename)
|
||||
|
||||
if (transform = transforms.find { |t| t.applies_to?(file) })
|
||||
attached += 1 if apply_transform(transform, file)
|
||||
elsif default_attach == :all
|
||||
# Default identity path. Blackline/Raven default — every safe
|
||||
# sandbox file that no transform claims attaches as-is. AIGL
|
||||
# passes default_attach: :none so non-transform files (the
|
||||
# agent's notes.md / map.md / timeline.md scratch) don't
|
||||
# auto-attach.
|
||||
attached += 1 if file.as_artifact.attach_to(message)
|
||||
end
|
||||
end
|
||||
rescue StandardError => e
|
||||
report(e, action: "attach_from_sandbox")
|
||||
end
|
||||
|
||||
# Returns true if a fresh trusted artifact was attached. Falsy on
|
||||
# already-trusted-attached, transform-raised, or duplicate-filename.
|
||||
def apply_transform(transform, file)
|
||||
if transform.purge_impostors?
|
||||
purged = Impostor.for(message: message, transform: transform)
|
||||
if purged.any?
|
||||
purged.each(&:purge!)
|
||||
# ActiveStorage purges the attachment + blob, but `message.artifacts`
|
||||
# holds the pre-purge collection in memory. Without resetting,
|
||||
# Artifact#already_attached_to? still sees the (just-purged) row
|
||||
# and shortcuts the trusted attach below.
|
||||
message.artifacts.reset
|
||||
end
|
||||
end
|
||||
return false if trusted_present?(transform)
|
||||
|
||||
artifact = transform.render(file)
|
||||
artifact.attach_to(message)
|
||||
rescue Transform::Error => e
|
||||
report(e, action: "transform_#{transform.class.name.demodulize}")
|
||||
false
|
||||
end
|
||||
|
||||
def trusted_present?(transform)
|
||||
message.artifacts.any? { |a| transform.trusted?(a) }
|
||||
end
|
||||
|
||||
def transform_owned_filenames
|
||||
transforms.flat_map(&:owned_filenames)
|
||||
end
|
||||
|
||||
def report(error, action:)
|
||||
Opencode::ErrorReporter.report(error, handled: true, severity: :warning,
|
||||
context: { feature: feature, action: action, message_id: message.id })
|
||||
end
|
||||
end
|
||||
end
|
||||
Reference in New Issue
Block a user